New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jenkins schema testing #733

Merged
merged 1 commit into from Apr 29, 2016

Conversation

Projects
None yet
2 participants
@tijmenb
Member

tijmenb commented Apr 29, 2016

This probably fixes persistent errors on ci:

https://ci.dev.publishing.service.gov.uk/job/govuk_specialist-publisher-rebuild_schema_tests/50/console

This app should not be setting GOVUK_APP_DOMAIN in jenkins at all - it’s using a really old pattern here. See this for example: alphagov/collections-publisher@fbd02be

Fix jenkins schema testing
This probably fixes persistent errors on ci.

This app should not be setting `GOVUK_APP_DOMAIN` in jenkins at all -
it’s using a really old pattern here. See this for example:

https://github.com/alphagov/collections-publisher/pull/128/commits/fbd02
be7adc9ce616b537efc408a1c8a7e37fbc9
@davidbasalla

This comment has been minimized.

Contributor

davidbasalla commented Apr 29, 2016

👍

@davidbasalla davidbasalla merged commit bb9f666 into master Apr 29, 2016

1 check passed

default Build #181 succeeded on Jenkins
Details

@davidbasalla davidbasalla deleted the fix-jenkins-schema-testing branch Apr 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment