Skip to content

/ static

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused global bar #1055

Merged
merged 1 commit into from May 24, 2017
Merged

Remove unused global bar #1055

merged 1 commit into from May 24, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 23, 2017

We're running unnecessary JS at the top of every page, and including JS and styles we don't need.

  • Remove global bar JS, styles, templates and tests
  • Global bar used for EU referendum was brought back for Article 50 notification – #947
  • It was partially removed in #1003

@timblair @nickcolley @Rosa-Fox
@fofr
Copy link
Contributor Author

@fofr fofr commented May 24, 2017

Double checked with @boffbowsh that we're ok to remove all of it.
@boffbowsh
boffbowsh approved these changes May 24, 2017
View changes
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented May 24, 2017

image

💯 💥
@fofr
Remove global bar
Loading status checks…
3231007 
Remove global bar JS, styles, templates and tests

* Global bar used for EU referendum was brought back for Article 50
notification – #947
* It was partially removed in #1003
@fofr fofr force-pushed the remove-global-bar branch to 3231007 May 24, 2017
@fofr fofr merged commit 7248cef into master May 24, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the remove-global-bar branch May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boffbowsh boffbowsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@fofr @nickcolley @boffbowsh
You can’t perform that action at this time.