Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Indent report a problem toggle and form correctly #1057
When on mobile, in some layouts the report a problem link and form get indented twice – once because of a 15px margin applied to #wrapper, and once again on report a problem itself.
The homepage is a special case, it uses #wrapper but removes the margin
The problem here is that the component should not define a width or horizontal margin, it should sit inside the parent wrapper.
I'd prefer to leave this as is and figure out what the work is to have this component sit within the pages' wrapper since this seems like it could break
@nickcolley Using the site on mobile, this bug continues to bother me. A "done properly" fix is complex and requires upgrading to the wrapper layout on our older pages, which I think will happen organically but over a long time.
A more complex fix is also more likely to break, or take more time testing/developing.
andysellick left a comment
I agree that fixing this properly is a wider issue and that it would be better to look into that, but I also think the current behaviour looks quite broken and this change fixes that. Lacking the time to look into a better fix, I think this works.
When on mobile, in some layouts the report a problem link and form get indented twice – once because of a 15px margin applied to #wrapper, and once again on report a problem itself. * If the link is nested within wrapper, don’t indent again * Keeps indentation if no wrapper is present The homepage is a special case, it uses #wrapper but removes the margin * Include site-width-container again with higher specificity for the homepage. This prevents the `0` margin resets from having affect.