Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS previously used by wrapper layout #1060

Merged
merged 5 commits into from Jul 18, 2017
Merged

Remove CSS previously used by wrapper layout #1060

merged 5 commits into from Jul 18, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 23, 2017

Each of these formats/patterns is now rendered using government-frontend. They have been removed from alphagov/frontend.

fofr added 5 commits May 23, 2017
This was a fix for map images and report a problem links on foreign
travel advice pages (not the listings).

Travel advice styling is all handled in government-frontend. These
blocks are not used.
Business support was removed from Frontend in
alphagov/frontend#1200

Business support is now a specialist_document with styles handled by
government-frontend.
Print links are rendered on guides and travel advice pages, they are
now rendered by government-frontend.
* Programmes have been converted to guides
* Classes `#wrapper.programme` and `programme-progression` no longer
occur
* Remove custom programme logic
* Guides, programmes and travel advice are all rendered by
government-frontend, none of them collapse the page list on mobile
* Only licence authorities on frontend still use this code (eg
https://www.gov.uk/temporary-events-notice/south-tyneside/apply and
https://github.com/alphagov/frontend/blob/efbd4c63e9b859d43b95f62423b569
b3b776bb9e/app/views/licence/_authority_details.html.erb)
* The JS for toggling lists isn’t accessible
* Display a list of pages instead
* Licence authorities have only two items in their page list
@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 19, 2017

I'd love to get a review on this.

@nickcolley nickcolley self-assigned this Jun 21, 2017
Copy link
Contributor

@cbaines cbaines left a comment

I haven't got enough context on this to spot problems from the diff, but I trust you to have done some testing, and to carefully deploy this 👍

@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 21, 2017

Having trouble checking this locally with alphagov/frontned need to get licence pages running to try it...

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 21, 2017

@nickcolley Didn't think Licensify used Static. Can you link to where it pulls it in?

@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 21, 2017

frontend uses licensify (without declaring it as a dependency) to populate those pages, so fails if I try to load without that endpoint setup...

Failed to open TCP connection to licensify.www.gov.uk:443 (getaddrinfo: Name or service not known)

https://github.com/alphagov/frontend/blob/49228d0cff8a4fca000f8b004fc307d94179889f/app/controllers/licence_controller.rb#L50

@fofr fofr merged commit 2e3046b into master Jul 18, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the remove-unused-css branch Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.