Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include integration tests for static component guide #1132

Merged
merged 2 commits into from Sep 14, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 7, 2017

Test that all components render without error

  • Require webmock minitest for stub_request in stub_shared_component_locales
  • Add an ActiveSupport concern to avoid hitting Slimmer for component guide requests (this matches the way we avoid hitting Slimmer when using Jasmine)
  • This doesn’t explicitly run Javascript, accessibility tests will not yet be running

Follow on from #1125
Part of https://trello.com/c/Yq9FFia1/

fofr added 2 commits Sep 6, 2017
* Require webmock minitest for `stub_request` in
stub_shared_component_locales
* Add an ActiveSupport concern to avoid hitting Slimmer for component
guide requests (this matches the way we avoid hitting Slimmer when
using Jasmine)
* This doesn’t explicitly run Javascript, accessibility tests will not
yet be running
@fofr fofr temporarily deployed to govuk-static-pr-1132 Sep 7, 2017 Inactive
@fofr fofr temporarily deployed to govuk-static-pr-1132 Sep 14, 2017 Inactive
@fofr fofr requested a review from h-lame Sep 14, 2017
@fofr fofr merged commit 04f6f7f into master Sep 14, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new issues
Details
@fofr fofr deleted the accessibility-testing branch Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.