Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow context in titles to be a link #1160

Merged
merged 1 commit into from Oct 2, 2017
Merged

Allow context in titles to be a link #1160

merged 1 commit into from Oct 2, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 29, 2017

  • Allows titles in Collections app to switch to the title component
  • It’s not clear how useful this feature is and if users are clicking on it, include data attributes to allow tracking and include caveat in the docs
  • Use API that matches HTML
  • Keep backwards compatibility with setting context to a string

https://govuk-static-pr-1160.herokuapp.com/component-guide/title

Used on:
https://www.gov.uk/topic/business-tax/vat

screen shot 2017-09-29 at 11 47 27

@fofr fofr temporarily deployed to govuk-static-pr-1160 Sep 29, 2017 Inactive
@fofr fofr requested a review from nickcolley Sep 29, 2017
@fofr fofr force-pushed the title-context-links branch Sep 29, 2017
@fofr fofr temporarily deployed to govuk-static-pr-1160 Sep 29, 2017 Inactive
@@ -22,6 +24,18 @@ examples:
data:
context: Publication
title: My page title
with_context_link:
description: |
It’s unclear if links in the context of a title are useful and are being clicked by users. Data attributes are included to track this behaviour.

This comment has been minimized.

@nickcolley

nickcolley Sep 29, 2017
Contributor

I love this!

* Allows titles in Collections app to switch to the title component
* It’s not clear how useful this feature is and if users are clicking
on it, include data attributes to allow tracking and include caveat in
the docs
* Use API that matches HTML
* Keep backwards compatibility with setting context to a string
* Use black focus styles to match breadcrumbs
@fofr fofr merged commit 5588798 into master Oct 2, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new issues
Details
@fofr fofr deleted the title-context-links branch Oct 2, 2017
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Oct 4, 2017

Maybe @alextea has some insight into how well it's working / if it still should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.