Allow context in titles to be a link #1160
Merged
Conversation
| @@ -22,6 +24,18 @@ examples: | |||
| data: | |||
| context: Publication | |||
| title: My page title | |||
| with_context_link: | |||
| description: | | |||
| It’s unclear if links in the context of a title are useful and are being clicked by users. Data attributes are included to track this behaviour. | |||
nickcolley
Sep 29, 2017
Contributor
I love this!
I love this!
* Allows titles in Collections app to switch to the title component * It’s not clear how useful this feature is and if users are clicking on it, include data attributes to allow tracking and include caveat in the docs * Use API that matches HTML * Keep backwards compatibility with setting context to a string * Use black focus styles to match breadcrumbs
|
Found some research on this pattern: |
|
Maybe @alextea has some insight into how well it's working / if it still should be included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://govuk-static-pr-1160.herokuapp.com/component-guide/title
Used on:
https://www.gov.uk/topic/business-tax/vat