Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style taxonomy sidebar like related links #1185

Merged
merged 4 commits into from Nov 6, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 6, 2017

We will be iterating both components as part of a multivariate test. This commit avoids a more thorough refactor to make them identical, in favour of making them alike. It’s an alternative to #1177.

  • Port related links styles directly from related links component
  • Makes two components similar
  • Increases spacing around links for easier clicking on mobile
  • Adds more examples

This PR does not address:

  • Need to use pub-c as the prefix
  • Inconsistent API between related links and taxonomy sidebar
  • Style re-use between components

https://govuk-static-pr-1185.herokuapp.com/component-guide/taxonomy_sidebar

Part of:
https://trello.com/c/FN3ppmn2/60-update-taxonomy-related-links-in-right-column-to-match-the-design-used-by-mainstream-browse-related-links

Screenshots

Old on left, new on right

screen shot 2017-11-06 at 11 58 46

screen shot 2017-11-06 at 11 59 21

Thin viewport

screen shot 2017-11-06 at 12 00 20

fofr added 4 commits Oct 30, 2017
* Taxon has children but no link to its own page
* Represents a tested state
We will be iterating both components as part of a multivariate test.
This commit avoids a more thorough refactor to make them both identical.

Port related links styles directly from related links component.
@fofr fofr temporarily deployed to govuk-static-pr-1185 Nov 6, 2017 Inactive
Copy link
Contributor

@andysellick andysellick left a comment

Looks good. Increasing the space around the links for mobile users is good, but was this tested on an actual device? Still seems like the links could be too small or close together.

@fofr
Copy link
Contributor Author

@fofr fofr commented Nov 6, 2017

@andysellick PR aims for consistency with related links rather than perfection in both. Better spacing is a side effect of related links being more spacious.

I have observed users interact with related links on mobile in user research without a problem, but the spacing might not be ideal for everyone.

We'll be doing design iterations on these elements in the next few sprints.

@fofr fofr merged commit 0e37bf3 into master Nov 6, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
@fofr fofr deleted the taxonomy-sidebar-like-related-links branch Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.