Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option select component #1262

Merged
merged 1 commit into from Jan 16, 2018
Merged

Remove option select component #1262

merged 1 commit into from Jan 16, 2018

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 12, 2018

PR depends on alphagov/finder-frontend#381 being merged and deployed

The option select component has moved to finder-frontend, closer to its
point of use. See: alphagov/finder-frontend#381

By moving the component to finder-frontend we can:

  • iterate the component close to its point of use
  • include the assets for the component only where they are needed
  • interact with the component in tests (rather than have a stubbed HTML tag containing JSON)

Originally added in #529

The option select component has moved to finder-frontend, closer to its
point of use. See: alphagov/finder-frontend#381

Originally added in #529
@fofr fofr changed the title [Do not merge] Remove option select component Remove option select component Jan 16, 2018
@fofr fofr merged commit 4b350e4 into master Jan 16, 2018
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
@fofr fofr deleted the remove-option-select branch Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.