Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to make global banner permanent #1955

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Dec 2, 2019

The default behaviour of the banner is to show for 3 pageviews, and then automatically hide. It can also be manually dismissed by the user.

We want the ability to have the banner be permanent, i.e: it will always show, regardless of the number of pageviews. This won't affect the user's ability to manually dismiss the banner.

How it works: if always_on is set to true, the view count for the global bar cookie is never updated which means the banner won't automatically hide as the count will never reach 3.

The default behaviour of the banner is to show for 3 pageviews, and then automatically hide. It can also be manually dismissed by the user.

We want the ability to have the banner be permanent, i.e: it will always show, regardless of the number of pageviews. This won't affect the user's ability to manually dismiss the banner.
@huwd
huwd approved these changes Dec 3, 2019
@vanitabarrett vanitabarrett merged commit cd7f07a into master Dec 3, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@vanitabarrett vanitabarrett deleted the test-permanent-banner branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.