Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to set user satisfaction survey URL #345

Merged
merged 2 commits into from Dec 4, 2013

Conversation

@bfirsh
Copy link
Contributor

bfirsh commented Dec 3, 2013

In whitehall we want to add different surveys for some pages. It could be possible to make this a slimmer processor so anything could set an arbitrary user satisfaction survey, but the survey is displayed using JavaScript anyway, so configuring it using GOVUK.userSatisfaction seems like a neater solution.

Thoughts?

bfirsh added 2 commits Dec 3, 2013
If showSurveyBar is called more than once, the query string gets
appended multiple times.
In whitehall we want to add different surveys for some pages.
It could be possible to make this a slimmer processor so anything
could set an arbitrary user satisfaction survey, but the survey
is displayed using JavaScript anyway, so configuring it using
GOVUK.userSatisfaction seems like a neater solution.
@bradwright

This comment has been minimized.

Copy link
Contributor

bradwright commented Dec 3, 2013

Seems sensible.

@mnowster

This comment has been minimized.

Copy link
Contributor

mnowster commented Dec 4, 2013

I'm going to ask one of my lot to take a look at this so to ensure it fits with mainstream stuff too...

@norm

This comment has been minimized.

Copy link
Contributor

norm commented Dec 4, 2013

WFM

@mnowster

This comment has been minimized.

Copy link
Contributor

mnowster commented Dec 4, 2013

Awesome. Thanks @norm 🌴

mnowster added a commit that referenced this pull request Dec 4, 2013
…sfaction-survey

Add method to set user satisfaction survey URL
@mnowster mnowster merged commit a0f2e08 into master Dec 4, 2013
@bfirsh

This comment has been minimized.

Copy link
Contributor Author

bfirsh commented Dec 4, 2013

Related: I wish the JS tests for static worked. :(

@alext

This comment has been minimized.

Copy link
Contributor

alext commented Dec 4, 2013

Pull-requests accepted...

@dsingleton dsingleton deleted the add-set-survey-url-to-user-satisfaction-survey branch Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.