Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't minify analytics initialisers in template #552

Merged
merged 1 commit into from Mar 2, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 2, 2015

In IE8 and below the minified inline javascript was inadvertently wiping out the GOVUK object, causing JS errors.

We aren’t sure exactly why it was wiping out the object, but by removing var and referring to window the error is eliminated.

Fix discovered by @edds after some excellent sleuthing.

In IE8 and below the minified inline javascript was inadvertently
wiping out the GOVUK object, causing JS errors.

We aren’t sure exactly why it was wiping out the object, but by
removing `var` and referring to window the error is eliminated.
edds added a commit that referenced this pull request Mar 2, 2015
Don't minify analytics initialisers in template
@edds edds merged commit e4883a6 into master Mar 2, 2015
1 check passed
1 check passed
default "Build #401 succeeded on Jenkins"
Details
@edds edds deleted the fix-ie8-analytics branch Mar 2, 2015
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.