Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frontend_toolkit’s analytics #557

Merged
merged 4 commits into from Mar 12, 2015
Merged

Use frontend_toolkit’s analytics #557

merged 4 commits into from Mar 12, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 12, 2015

The analytics API from #549 was ported across to the govuk_frontend_toolkit (alphagov/govuk_frontend_toolkit#162) so that non rails apps can use the code (specifically, spotlight).

  • Update the frontend toolkit gem and pull in the new analytics API from the gem
  • Remove the old files and tests
  • Create a StaticTracker for doing static specific analytics tasks, such as handling slimmer custom variables, reading analytics cookies and setting certain custom dimensions
  • Print intent and JavaScript error trackers now need to be started. Start them after registering the first pageview.

Analytics documentation:
https://github.com/alphagov/govuk_frontend_toolkit/blob/master/docs/analytics.md

fofr added 4 commits Mar 11, 2015
* Pick up analytics scripts which have been ported to the toolkit in:
alphagov/govuk_frontend_toolkit#162
* Remove static’s trackers and specs, these were ported across to the
toolkit
* Remove static’s error and print intent tracking, use the gem versions
instead
* Create a StaticTracker for doing static specific analytics tasks,
such as handling slimmer custom variables, reading analytics cookies
and setting certain custom dimensions
Print intent and JavaScript error trackers now need to be started.
Start them after registering the first pageview.
Highlight that this is a universal and classic tracker and point to the
source and documentation.
@benilovj
Copy link
Contributor

@benilovj benilovj commented Mar 12, 2015

👍

benilovj added a commit that referenced this pull request Mar 12, 2015
Use frontend_toolkit’s analytics
@benilovj benilovj merged commit e6857ed into master Mar 12, 2015
1 check passed
1 check passed
default "Build #415 succeeded on Jenkins"
Details
@benilovj benilovj deleted the moved-analytics branch Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.