Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom variable in a cookie shim #564

Merged
merged 1 commit into from Mar 25, 2015
Merged

Remove custom variable in a cookie shim #564

merged 1 commit into from Mar 25, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 25, 2015

Do not merge until alphagov/frontend#777 is deployed

The technique for setting analytics calls for a following page was updated in #560 and uses of the old technique updated in alphagov/frontend#777.

  • Remove shim
  • Simplify tests
The technique for setting analytics calls for a following page was
updated in #560 and uses of the
old technique updated in alphagov/frontend#777.

* Remove shim
* Simplify tests
@benilovj
Copy link
Contributor

@benilovj benilovj commented Mar 25, 2015

👍 merge when ready.

@benilovj
Copy link
Contributor

@benilovj benilovj commented Mar 25, 2015

alphagov/frontend#777 is now deployed, merging.

benilovj added a commit that referenced this issue Mar 25, 2015
Remove custom variable in a cookie shim
@benilovj benilovj merged commit e04bdfa into master Mar 25, 2015
1 check passed
@benilovj benilovj deleted the remove-cookie-shim branch Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants