Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Analytics classic #597

Merged
merged 5 commits into from Jun 1, 2015
Merged

Remove Google Analytics classic #597

merged 5 commits into from Jun 1, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 26, 2015

To be deployed 2 June.

Following on from alphagov/govuk_frontend_toolkit#194

On 2 June we plan to deprecate Google Analytics classic on GOV.UK, from then on we will only use Universal analytics. Google Analytics classic data collection techniques are being deprecated by Google. We should no longer support classic and new tracking should use only Universal.

  • Bump govuk_frontend_toolkit to pull in latest analytics
  • Remove references to classic tracker
  • Remove classic specific arguments (eg custom variable name and scope)
  • Update references of GOVUK.Tracker to GOVUK.Analytics
  • Rename StaticTracker to StaticAnalytics to match upstream refactor

Because the StaticTracker and StaticTrackerSpec files have been renamed, when reviewing I suggest looking at the individual commits.

@alicebartlett
Copy link
Contributor

@alicebartlett alicebartlett commented May 28, 2015

👍 LGTM

fofr added 5 commits May 14, 2015
Google Analytics classic data collection techniques are being
deprecated by Google. We no longer need to support classic and any new
tracking should use only Universal.
The Tracker object was renamed in frontend_toolkit, update the
StaticTracker object to correspond.
Pickup changes that remove Google Analytics classic
@fofr fofr force-pushed the remove-classic-analytics branch from 0c9849f to 5b610a1 Jun 1, 2015
@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 1, 2015

I've rebased this against master to pick up @edds’s latest change.

bradwright added a commit that referenced this pull request Jun 1, 2015
@bradwright bradwright merged commit aedb9d8 into master Jun 1, 2015
1 check passed
1 check passed
default "Build #508 succeeded on Jenkins"
Details
@bradwright bradwright deleted the remove-classic-analytics branch Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.