Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show closing quote on govspeak blockquotes #611

Merged
merged 2 commits into from Jul 2, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 2, 2015

When writing content and converting to govspeak, the .last-child class isn’t automatically added to the last <p> tag in a <blockquote>. Only Whitehall currently does this

  • Use the last-child pseudo selector to enable end quotes on all apps

A closing quote will not show on IE8 (no :last-child support), which currently represents 3.5% of pageviews.

https://trello.com/c/tTYHNfWt/7-closing-quotations-marks-should-show-in-manuals-small

cc @edds

fofr added 2 commits Jul 2, 2015
When writing content and converting to govspeak, the `last-child` class
isn’t automatically added to the last p tag in a block quote. Only
Whitehall does this, and that’s using a different set of styles.

* Use the last-child pseudo selector to enable end quotes on all apps

A closing quote will not show on IE8 (no last-child support), which
currently represents 3.5% of pageviews. (IEs older than 8 don’t support
pseudo elements either)
edds added a commit that referenced this pull request Jul 2, 2015
Show closing quote on govspeak blockquotes
@edds edds merged commit 7dc7ccb into master Jul 2, 2015
1 check passed
1 check passed
default "Build #525 succeeded on Jenkins"
Details
@edds edds deleted the future-proof-blockquotes branch Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.