Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery to 1.11.3 #628

Merged
merged 2 commits into from Jul 30, 2015
Merged

Upgrade jQuery to 1.11.3 #628

merged 2 commits into from Jul 30, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 27, 2015

https://trello.com/c/BMpUGtKT/62-upgrade-jquery-on-gov-uk

Update jQuery to 1.11.X to pickup 3 years worth of bug fixes new APIs and features (eg better CSS3 support, smaller, faster)

Major releases

Breaking changes resolved in previous PRs:

  • Switching from $.live to $.on
  • Replacing uses of attr() with prop() where appropriate
  • Shimming $.browser for the plugins we use that still need it (jquery.history.js used by tabs, jquery.player.js – Accessible Media Player)

Prep for this upgrade

(When deploying this change we should keep an eye on the real time JavaScript errors in Google Analytics)

fofr added 2 commits Jul 24, 2015
Tests begun to fail with jQuery 1.11.3

The existing `beforeEach` and `afterEach` weren’t adequately cleaning
up their HTML once a test was run. This led to multiple containers,
which led to the newer jQuery picking the first empty one, rather than
a later one containing the element we’re looking for.

* Declare a new $block at the beginning of each template
* Remove the $block at the end
* Simplify click handling on elements
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Jul 27, 2015

Third party javascript should go in vendor/assets/javascripts/ - could we move it?

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 27, 2015

Spoke to @jamiecobbett about moving jquery to the vendor directory, will do this as a separate PR later.

@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Jul 30, 2015

Talked to @fofr about the change a couple of days ago and was happy.

This has been running on for a day, with no uptick in reported JS errors, so we're feeling confident rolling this out today.

dsingleton added a commit that referenced this issue Jul 30, 2015
@dsingleton dsingleton merged commit 3d5939c into master Jul 30, 2015
1 check passed
@dsingleton dsingleton deleted the upgrade-jquery branch Jul 30, 2015
@fofr fofr mentioned this pull request Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants