Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make report a problem link always underlined and grey #629

Merged
merged 1 commit into from Jul 27, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 27, 2015

In Whitehall, link styles are wrapped in a #whitehall-wrapper class, so they have a higher specificity, meaning they are purple (there's no href, so the link is deemed visited) and not underlined (Whitehall link styles are currently inconsistent with the rest of GOV.UK – see alphagov/whitehall#712)

  • Make sure the link is always grey and always underlined, !important ensures this

Before

screen shot 2015-07-27 at 13 59 11

After

screen shot 2015-07-27 at 13 59 43

In Whitehall, link styles are wrapped in a #whitehall-wrapper class, so
they have a higher specificity, meaning they are either blue or purple
and not underlined.

(Whitehall link styles are inconsistent with the rest of GOV.UK)
@fofr fofr force-pushed the fix-report-problem-link-color branch to f8304a1 Jul 27, 2015
dsingleton added a commit that referenced this pull request Jul 27, 2015
Make report a problem link always underlined and grey
@dsingleton dsingleton merged commit 2b64077 into master Jul 27, 2015
1 check passed
1 check passed
default "Build #552 succeeded on Jenkins"
Details
@dsingleton dsingleton deleted the fix-report-problem-link-color branch Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.