Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up the size of the checkbox on option selects #645

Merged
merged 1 commit into from Sep 4, 2015

Conversation

@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Sep 4, 2015

We’re upping the size of checkboxes generally across the site. Originally this code just used a negative margin-left to pull the checkbox to the left, but this also pulls the following text regardless of padding. By floating it left the following text will respect the padding boundary set against the label.

Most browsers look good, IE9 is the odd one out. It looks OK but is slightly out of position and cramped. I’m assuming we’ll go down the same route as on alphagov/govuk_elements#98 though.

Screenshots:

Chrome (Android)

android_chrome

Safari (iOS)

ios_safari

Chrome (OS X)

osx_chrome

Firefox (OS X)

osx_firefox

Safari (OS X)

osx_safari

IE8 (Windows 7)

win7_ie8

IE9 (Windows 7)

win7_ie9

Chrome (Windows 10)

win10_chrome

Edge (Windows 10)

win10_edge

Firefox (Windows 10)

win10_firefox

IE11 (Windows 10)

win10_ie11

Opera (Windows 10)

win10_opera

We’re upping the size of checkboxes generally across the site. Originally this code just used  a negative margin-left to pull the checkbox to the left, but this also pulls the following text regardless of padding. By floating it left the following text will respect the padding boundary set against the label.
@alicebartlett
Copy link
Contributor

@alicebartlett alicebartlett commented Sep 4, 2015

Good work Robin, thanks for testing so thoroughly, these screenshots make this a trivially easy pull request to merge ^_^

alicebartlett added a commit that referenced this pull request Sep 4, 2015
Up the size of the checkbox on option selects
@alicebartlett alicebartlett merged commit 62ca3ea into master Sep 4, 2015
1 check passed
1 check passed
@govuk-ci
default "Build #583 succeeded on Jenkins"
Details
@alicebartlett alicebartlett deleted the option_select_checkbox_size branch Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants