Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component unit test to component generator #696

Merged
merged 3 commits into from Jan 4, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 23, 2015

When generating a component include a unit test.

The basic unit test asserts that the component template renders with the expected govuk- class and that no errors are thrown when no parameters are passed in. It’s modelled on the alpha_label_test.

Includes documentation about component unit tests

https://trello.com/c/NLkm3EDy/17-unit-test-components

cc @dsingleton

@fofr fofr force-pushed the component-generator-test branch 3 times, most recently Dec 23, 2015
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Jan 4, 2016

Huge improvement 👍, especially to the docs.

Any chance you could squash 66803de and 47321ce? I'd be happy merging without that, but it would make the history clean 😄

fofr added 2 commits Dec 23, 2015
When generating a component include a unit test.

The basic unit test asserts that the component template renders with
the expected `govuk-` class and that no errors are thrown when no
parameters are passed in. It’s modelled on the alpha_label_test.
@fofr fofr force-pushed the component-generator-test branch to de22950 Jan 4, 2016
dsingleton added a commit that referenced this pull request Jan 4, 2016
Add component unit test to component generator
@dsingleton dsingleton merged commit 9cc4177 into master Jan 4, 2016
1 check passed
1 check passed
default "Build #738 succeeded on Jenkins"
Details
@dsingleton dsingleton deleted the component-generator-test branch Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.