Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This work follows the principles:
Changes to components:
This story has highlighted a need for Sass linting, so that styles are written consistently across apps.
As part of component standardising we don’t want the outer component container to have top margins. This component is used in finder frontend and manuals. In finder frontend the style is overwritten by app specific styles, in manuals it's not necessary.
Document footers appear in a consistent place on a page. Add a default bottom margin so that apps do not have to add manual styles to separate it from the “report a problem” link. Currently only used by specialist-frontend and government-frontend.
Give option selects a margin so that each app using them doesn’t need to provide them itself. Base on value used in finder-fronted: https://github.com/alphagov/finder-frontend/blob/09dba3aa9b7b4633932b71b 9593302c7d48f30f0/app/assets/stylesheets/finder_frontend.scss#L155
* Nav appears beneath content by default, a top margin makes sense in this case * Add a bottom margin by default, something will always follow it * DRY up some of the styles Margin use case: https://github.com/alphagov/finder-frontend/blob/09dba3aa9b7b4633932b71b 9593302c7d48f30f0/app/assets/stylesheets/finder_frontend.scss#L347
How did you test the changes and how confident are we there aren't any unintended changes? (I tried to fix report-a-problem alignment in the past and managed to break an edge case
@dsingleton I based the
@dsingleton Regarding "Report a problem", when that markup is in #wrapper, then wrapper is providing all of the page positioning and margins, in that instance it doesn't need any side margins. Tested on specialist-frontend, finder-frontend, government-frontend and frontend.
Metadata component should have a default margin as a different type of content usually follows. Follow the government-frontend example and use a responsive margin. Component is also used by specialist-frontend and finder-frontend. Specialist front-end needs to be updated before this change is applied.