Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sass linting to components #734

Merged
merged 2 commits into from Feb 16, 2016
Merged

Add Sass linting to components #734

merged 2 commits into from Feb 16, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 16, 2016

  • Add sass linting via govuk-lint update, start by linting only components with jenkins
  • Fix sass offences. Mostly whitespace between selectors, and between properties and values.

Some notable changes:

  • Change hr from #ccc to $border-colour (which has a stronger
    contrast and matches $grey-2) in govspeak
  • Use // comments rather than /* */ so they aren’t output
  • Reduce nesting within contact CSS from 6 levels to 5 by moving the
    email word-break styles up a level – they don’t need to be as specific.
  • Don’t lint magna charta
fofr added 2 commits Feb 16, 2016
* Start by linting only components
Mostly whitespace between selectors, and between properties and values.

Some notable changes:
* Change `hr` from #ccc to $border-colour (which has a stronger
contrast and matches $grey-2) in govspeak
* Use `//` comments rather than `/* */` so they aren’t output
* Reduce nesting within contact CSS from 6 levels to 5 by moving the
email word-break styles up a level – they don’t need to be as specific.
* Don’t lint magna charts
boffbowsh added a commit that referenced this issue Feb 16, 2016
Add Sass linting to components
@boffbowsh boffbowsh merged commit 0705153 into master Feb 16, 2016
1 check passed
@boffbowsh boffbowsh deleted the linting branch Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants