Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid ARIA role #737

Merged
merged 1 commit into from Feb 25, 2016
Merged

Remove invalid ARIA role #737

merged 1 commit into from Feb 25, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 19, 2016

@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Feb 19, 2016

@@ -2,7 +2,7 @@
breadcrumbs ||= []
%>
<div class="govuk-breadcrumbs">
<ol role="breadcrumbs">

This comment has been minimized.

@jamiecobbett

jamiecobbett Feb 19, 2016
Contributor

🍞 🎢

@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Feb 22, 2016

Any reason not to use navigation, as per the Sandbox? We should use that, or just ship this, either one would be an improvement.

@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Feb 23, 2016

@aduggin , do you have an opinion here?

dsingleton added a commit that referenced this pull request Feb 25, 2016
Remove invalid ARIA role
@dsingleton dsingleton merged commit e5d2978 into master Feb 25, 2016
1 check passed
1 check passed
default "Build #845 succeeded on Jenkins"
Details
@dsingleton dsingleton deleted the remove-breadcrumbs-role branch Feb 25, 2016
fofr added a commit that referenced this pull request May 25, 2016
* Breadcrumbs is not a valid ARIA role
* It is not being used for styling

We previously removed from the component:
#737

Was added in:
#238
@fofr
Copy link
Contributor Author

@fofr fofr commented May 25, 2016

We haven't gone back to this to improve the breadcrumbs component yet, but I've found this PR from 2013 that specifically removed the nav elements citing accessibility tests:
#238

fofr added a commit to alphagov/manuals-frontend that referenced this pull request May 25, 2016
`role="breadcrumbs”` is not a thing.
https://www.w3.org/TR/wai-aria/roles#role_definitions

We previously removed from the component:
alphagov/static#737

Was added in:
#4
fofr added a commit to alphagov/contacts-admin that referenced this pull request May 25, 2016
`role="breadcrumbs"` is not a thing.
https://www.w3.org/TR/wai-aria/roles#role_definitions

We previously removed from the component:
alphagov/static#737
fofr added a commit to alphagov/contacts-frontend that referenced this pull request May 25, 2016
`role="breadcrumbs"` is not a thing.
https://www.w3.org/TR/wai-aria/roles#role_definitions

We previously removed from the component:
alphagov/static#737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.