Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of attachment thumbs in IE8 #763

Merged
merged 1 commit into from Mar 29, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 29, 2016

IE8 incorrectly asserts the "max-width: 100%" rule to be 0 because of the collapsed width on its floating container.

  • Reset the max-width so that thumbnails render at the specified width

For reference:
http://www.456bereastreet.com/archive/201202/using_max-width_on_images_can_make_them_disappear_in_ie8/

Zendesk:
https://govuk.zendesk.com/agent/tickets/1287244

Before

screen shot 2016-03-29 at 11 30 31

After

screen shot 2016-03-29 at 11 30 13

IE8 incorrectly asserts the "max-width: 100%" rule to be 0
because of the collapsed width on its floating container.

* Reset the max-width so that thumbnails render at the specified width

For reference:
http://www.456bereastreet.com/archive/201202/using_max-width_on_images_c
an_make_them_disappear_in_ie8/
@boffbowsh boffbowsh merged commit 7151a4c into master Mar 29, 2016
1 check passed
1 check passed
default "Build #952 succeeded on Jenkins"
Details
@boffbowsh boffbowsh deleted the fix-attachment-thumbs-ie8 branch Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.