Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add political-status and publishing-government to analytics #777

Merged
merged 1 commit into from Apr 26, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 25, 2016

  • Derive political status based on current-ness of government and political state of content
  • Use government slug for publishing-government
  • Only include analytics tags if both government and political keys are present

Based on political and government representations in content items, added in: alphagov/govuk-content-schemas#290

And the existing logic in Whitehall:
https://github.com/alphagov/whitehall/blob/bf784b05c467d3ce576fc8729810d21078cbc69c/app/helpers/document_helper.rb#L272-L288
https://github.com/alphagov/whitehall/blob/bf784b05c467d3ce576fc8729810d21078cbc69c/test/functional/publications_controller_test.rb#L668-L691

* Derive political status based on current-ness of government and
political state of content
* Only include analytics tags if both government and political keys are
present

Based on political and government representations in content items,
added in: alphagov/govuk-content-schemas#290
@tvararu
Copy link
Contributor

@tvararu tvararu commented Apr 26, 2016

👍

@tvararu tvararu merged commit b74433e into master Apr 26, 2016
1 check passed
1 check passed
default "Build #1020 succeeded on Jenkins"
Details
@tvararu tvararu deleted the analytics-history-mode branch Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.