Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new survey test - decrease frequency that survey shows for 48 hours #779

Merged
merged 3 commits into from Apr 29, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 28, 2016

  • Remove old test, add new test, fix pending spec.
  • Test will run from May 4 to May 5.

https://trello.com/c/YN1CU7jB/385-gov-uk-survey-test-for-may-small

The test has run. Remove in preparation for another test.
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 28, 2016

Looks like Jenkins is having problems.

@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Apr 29, 2016

Looks like Jenkins is having problems.

Same issue as we saw the other day, one of the jenkins machines is unavailable and the job is running on a different one that is failing. Being looked at by @alexmuller at the moment.

@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Apr 29, 2016

Changes look good to me, be happy to merge once the CI issues are resolved.

fofr added 2 commits Apr 28, 2016
* Allow the frequency to be changed
* Fix previously pending/randomly failing test
Between May 4 and May 5 we will run a test which will reduce the
frequency of the survey bar to 1 in 100 page views.
@fofr fofr force-pushed the survey-test branch to be98fd6 Apr 29, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 29, 2016

Fixed tests: surveyFrequency() { } is fine when not minified, but causes a parse error when minified because it should be surveyFrequency: function() {}

@dsingleton dsingleton merged commit 2d5bb5b into master Apr 29, 2016
1 check passed
1 check passed
default "Build #1044 succeeded on Jenkins"
Details
@boffbowsh boffbowsh deleted the survey-test branch Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.