Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide EU banner from 26 May #787

Merged
merged 1 commit into from May 12, 2016
Merged

Hide EU banner from 26 May #787

merged 1 commit into from May 12, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 12, 2016

  • Check the current date and hide the banner for any time after midnight 26 May
  • Set the current date to 25 May for the purpose of tests
  • Include a specific test for the banner not showing on 26 May

https://trello.com/c/Bv2wbXTa/403-site-wide-banner-banner-not-visible-after-26th-may

@dsingleton @boffbowsh

@fofr fofr force-pushed the hide-eu-banner-from-26-may branch to beaa8dc May 12, 2016
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented May 12, 2016

LGTM.

@boffbowsh can you give this an extra set of eyes? (because time based stuff)

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented May 12, 2016

Nice date mocking 👍

@boffbowsh boffbowsh merged commit 8f0c0d1 into master May 12, 2016
1 check passed
1 check passed
default "Build #1062 succeeded on Jenkins"
Details
* Check the current date and hide the banner for any time after afternoon of 26 May
* Set the current date to before cut-off for the purpose of tests
* Include a specific test for the banner not showing on 26 May
@36degrees 36degrees deleted the hide-eu-banner-from-26-may branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.