Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Remove global banner bar #789

Merged
merged 1 commit into from May 25, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 13, 2016

Deploy on May 25
https://trello.com/c/npd5H4IW/405-sitewide-banner-remove-supporting-banner-code

  • Delete inline class toggle JS and spec
  • Delete global bar markup and module for dismissing/storing view count
  • Remove styles

We don’t intend to use this again soon.

Reverts #769

* Delete inline class toggle JS and spec
* Delete global bar markup and module for dismissing/storing view count
* Remove styles

We don’t intend to use this again soon.

Reverts #769
@gpeng
Copy link
Contributor

@gpeng gpeng commented May 17, 2016

👍

@dsingleton dsingleton merged commit 62dd3fb into master May 25, 2016
1 check passed
1 check passed
default "Build #1068 succeeded on Jenkins"
Details
@dsingleton dsingleton deleted the remove-global-banner branch May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.