Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid breadcrumbs aria role from base template #796

Merged
merged 1 commit into from May 26, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 25, 2016

  • Breadcrumbs is not a valid ARIA role
  • It is not being used for styling

We previously removed from the component: #737
Was added in: #238

* Breadcrumbs is not a valid ARIA role
* It is not being used for styling

We previously removed from the component:
#737

Was added in:
#238
@gemmaleigh
Copy link
Contributor

@gemmaleigh gemmaleigh commented May 25, 2016

@tombye
Copy link
Contributor

@tombye tombye commented May 26, 2016

I think this change was also on the accessibility hack day list too so 👍

@nickcolley nickcolley merged commit 3a754ad into master May 26, 2016
1 check passed
1 check passed
@govuk-ci
default "Build #1088 succeeded on Jenkins"
Details
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented May 26, 2016

Thanks @fofr 👍 🎉

@36degrees 36degrees deleted the remove-bad-role branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants