Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylesheets duplicated in header-footer-only #797

Merged
merged 1 commit into from Jun 6, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 26, 2016

styleguide/conditionals2, helpers/footer and helpers/header are
all already included in header-footer-only. This means their styles are duplicated in the generated CSS.

It seems odd that header and footer weren't removed when switching to header-footer-only, but I haven't found any explicit reason for them to be kept. Nothing appears to override those styles.

For an example, search for #user-satisfaction in https://assets.digital.cabinet-office.gov.uk/static/static-35b681259fdcd07f543889e5711c8dbcf7728a3fa318c4881d0ba2e3d8bb3ac0.css

`styleguide/conditionals2`, `helpers/footer` and `helpers/header` are
all already included in `header-footer-only`.

This means their styles are duplicated in the generated CSS.
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 3, 2016

This looks good to me, it is possible that the order in which the duplicates were imported could break something.

For example if one of the imports before the duplicate import is being overridden...

As far as I can tell that's not an issue. 👍

@dsingleton - can you confirm the above? :)

@dsingleton dsingleton merged commit 9f90b3f into master Jun 6, 2016
1 check passed
1 check passed
default "Build #1090 succeeded on Jenkins"
Details
@dsingleton dsingleton deleted the stop-duplicate-styles branch Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.