Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump template and toolkit #799

Closed
wants to merge 1 commit into from
Closed

Bump template and toolkit #799

wants to merge 1 commit into from

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 26, 2016

Update govuk_frontend_toolkit to 4.12.0

https://github.com/alphagov/govuk_frontend_toolkit/blob/master/CHANGELOG.md

4.12.0

Increase button padding to match padding from GOV.UK elements. If you have UI which depends on the padding set by the button mixin in the frontend toolkit and this is not overridden by button padding set by GOV.UK elements, this change will affect it.

4.11.0

Remove the GDS-Logo font-face definition
Move the @Viewport statements to govuk_template. If you upgrade to this version of govuk_frontend_toolkit and you’re also using govuk_template you’ll need to upgrade that to at least 0.17.2 to maintain compatibility with desktop IE10 in snap mode.

Update govuk_template to 0.17.2

https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md

0.17.2

Fix a bug with the skip-to-content link and iOS Voiceover
Migrate @Viewport statement from govuk_frontend_toolkit

0.17.1

Reduce file size of template: removes HTML comments, type attributes on scripts, and uses HTML5 charset declaration.
Switch external link media query to be mobile first
Sass file cleanups
Replace old grid mixins with newer grid from frontend toolkit
Remove duplicate grey variables

@fofr fofr closed this May 26, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented May 26, 2016

There is some weirdness introduced by this update, which is a double <meta> tag appearing in head:

Frontend renders:

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta charset="utf-8">
@fofr
Copy link
Contributor Author

@fofr fofr commented May 26, 2016

Changes also seem to break the footer (headings change colour, block is indented incorrectly):

Before

screen shot 2016-05-26 at 15 10 47

After

screen shot 2016-05-26 at 15 10 19

@fofr
Copy link
Contributor Author

@fofr fofr commented May 26, 2016

Fixed footer alignment in d332eba

@fofr
Copy link
Contributor Author

@fofr fofr commented May 27, 2016

Superceded by #801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.