Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update govuk_frontend_toolkit to 4.12.0
Increase button padding to match padding from GOV.UK elements. If you have UI which depends on the padding set by the button mixin in the frontend toolkit and this is not overridden by button padding set by GOV.UK elements, this change will affect it.
Remove the GDS-Logo font-face definition
Update govuk_template to 0.17.3
Fix bug with heading colours in footer
Fix a bug with the skip-to-content link and iOS Voiceover
Reduce file size of template: removes HTML comments, type attributes on scripts, and uses HTML5 charset declaration.
* Update govuk_frontend_toolkit to 4.12.0 https://github.com/alphagov/govuk_frontend_toolkit/blob/master/CHANGELOG .md * Bump govuk_template to 0.17.3 https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md
This still has the peculiar double meta charset issue:
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta charset="utf-8">
This doesn't break anything, and I think it's worth making the updates to get the latest changes in. This should be investigated separately, and probably involves some obscure Rails magic. cc @boffbowsh
With the toolkits bump it includes updates to buttons which improve the padding on buttons, GOV.UK already includes overrides to the previous padding of buttons so this commit adds a note to remove this as part of a wider review in favour of the padding now used in the toolkit