Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery to 1.12.4 #869

Merged
merged 1 commit into from Jan 4, 2017
Merged

Upgrade jQuery to 1.12.4 #869

merged 1 commit into from Jan 4, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 20, 2016

Performance of the selector engine has improved thanks to a shortcut path that immediately uses precompiled Sizzle selectors when the selector cannot be processed by the native querySelectorAll or matchesSelector methods. This results in a significant speedup in some real-world cases.

Release notes:
https://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
https://blog.jquery.com/2016/02/22/jquery-1-12-1-and-2-2-1-released/
https://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/
https://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/
https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/

Similar to previous upgrade jQuery PR:
#628

(Holding off merging until upgrade PRs on other repositories are merged.)

@fofr fofr changed the title [DO NOT MERGE] Upgrade jQuery to 1.12.4 Upgrade jQuery to 1.12.4 Jan 3, 2017
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jan 3, 2017

Nice work 👍

I'd like to test it like the previous PR and if possible point https://github.com/alphagov/govuk-component-guide at the integration deployed version of static.

As a bonus would be good to profile before and after, see if this improves rendering of pages like alphagov/manuals-frontend#187 👁 👁

@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 4, 2017

Branch deployed to integration for testing.

I've tested in Chrome:

  • Collections (browse)
  • Smart answers
  • Search facets
  • Finder facets
  • Licence finder
  • Video player
  • Analytics
@fofr fofr merged commit 105679d into master Jan 4, 2017
1 check passed
1 check passed
default "Build #1373 succeeded on Jenkins"
Details
@fofr fofr deleted the upgrade-jquery branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.