Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery to 1.12.4 (take 2) #878

Merged
merged 2 commits into from Jun 14, 2017
Merged

Upgrade jQuery to 1.12.4 (take 2) #878

merged 2 commits into from Jun 14, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 10, 2017

Same as #869 but with added fix for jquery tabs.

Performance of the selector engine has improved thanks to a shortcut path that immediately uses precompiled Sizzle selectors when the selector cannot be processed by the native querySelectorAll or matchesSelector methods. This results in a significant speedup in some real-world cases.

Release notes:
https://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/
https://blog.jquery.com/2016/02/22/jquery-1-12-1-and-2-2-1-released/
https://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/
https://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/
https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/

Similar to previous upgrade jQuery PR:
#628

@36degrees
Copy link
Member

@36degrees 36degrees commented Feb 9, 2017

I've changed the required status checks for this repo. You'll need to rebase this branch against master so that this branch gets a Jenkinsfile can be built against new CI.

@fofr
Copy link
Contributor Author

@fofr fofr commented Feb 9, 2017

I'm holding off merging this until we have Smokey tracking JS errors.

fofr added 2 commits Jan 10, 2017
This reverts commit a35c1f0.

Linting conflicts fixed in:
	test/integration/templates/chromeless_test.rb
	test/integration/templates/error_4xx_test.rb
	test/integration/templates/error_5xx_test.rb
	test/integration/templates/header_footer_only_test.rb
	test/integration/templates/homepage_test.rb
	test/integration/templates/wrapper_test.rb
	test/integration/templates/wrapper_with_js_last.rb
As of jQuery 1.12 the selector `a[href$=abc]` is invalid and requires
quotes around the value part.

Fixes failing test

See:
jquery/jquery#2824
#874
@fofr fofr force-pushed the upgrade-jquery branch to 38ca2e9 Apr 11, 2017
@fofr fofr changed the title [DO NOT MERGE] Upgrade jQuery to 1.12.4 (take 2) Upgrade jQuery to 1.12.4 (take 2) Apr 11, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 11, 2017

Smokey JS tests are working now (they alerted us to an error with tabs this morning).
It'd be good to get this upgrade out now.

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 5, 2017

I'd dearly love for someone to review this. Is 🍰 required?

@andysellick andysellick self-requested a review Jun 6, 2017
@fofr fofr merged commit 16cc2ca into master Jun 14, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the upgrade-jquery branch Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.