Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom organisation logos #894

Merged
merged 2 commits into from Feb 16, 2017
Merged

Add support for custom organisation logos #894

merged 2 commits into from Feb 16, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 8, 2017

Goes with alphagov/govuk-content-schemas#514 and alphagov/government-frontend#246
Part of https://trello.com/c/HtSGDoRb/594-add-organisation-logos-that-are-images-to-content-item-2

  • Add support for logos for organisations such as HM Prison Service, Land Registry, Environment Agency have a custom logo image.
  • Update component to accept an image if provided

screen shot 2017-02-08 at 14 47 07
screen shot 2017-02-08 at 14 47 29

@36degrees
Copy link
Member

@36degrees 36degrees commented Feb 9, 2017

I've changed the required status checks for this repo. You'll need to rebase this branch against master so that this branch gets a Jenkinsfile can be built against new CI.

@gpeng
gpeng approved these changes Feb 10, 2017
<img
class="logo-image"
src="<%= organisation[:image][:url] %>"
<% if organisation[:image][:alt_text] %>alt="<%= organisation[:image][:alt_text] %>"<% end %>

This comment has been minimized.

@bevanloon

bevanloon Feb 10, 2017
Contributor

is it worth making the alt text the organisation name if it isn't present?

This comment has been minimized.

@fofr

fofr Feb 13, 2017
Author Contributor

The name that comes through is the formatted one. I'd like to avoid stripping out the HTML in favour of specifying. It should always be provided.

This comment has been minimized.

@bevanloon

bevanloon Feb 14, 2017
Contributor

👍

* Toolkit has been updated to pass linting checks
@fofr fofr force-pushed the custom-org-logos branch Feb 16, 2017
Logos for organisations such as HM Prison Service, Land Registry,
Environment Agency have a custom logo image.

Update component to accept an image if provided
@fofr fofr force-pushed the custom-org-logos branch to 5dd0717 Feb 16, 2017
@fofr fofr changed the title [Do not merge] Add support for custom organisation logos Add support for custom organisation logos Feb 16, 2017
@fofr fofr merged commit 1b6a884 into master Feb 16, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@barrucadu barrucadu deleted the custom-org-logos branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.