Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Don't open print links in a new window #917
So I know some of our print pages do funky stuff on a new page.
Would this break that functionality?
It's also worth noting the print links should not go to an external domain.
I don't feel so comfortable with this change because I don't have lots of devices to test this against, printing behaves very different depending on the operating system so I worry this would introduce an odd behaviour.
That being said, I've not seen an evidence of that testing to make this change in the first place.
Will let someone else also have a look.
My strength of opinion on this is low, 3/10 for context.
My reckon would be that it opens in a new page to reduce the chance of users getting stuck on the print page - as we know some users have difficulty navigating via the back button.
I'm not sure the reasons given for the change are convincing enough to make it.
There might be other benefits/context i'm not aware of though.
I get the whole 'give users control over whether things open in a new window or not', but when it comes to print links specifically I think there's a pretty common pattern for doing so. I'm not convinced that we should remove it without further research.