Fix regression: Don't style strong text as bold unless using rich govspeak #922
Conversation
|
no bold |
app/assets/stylesheets/govuk-component/_govspeak.scss
Outdated
| @@ -20,6 +20,10 @@ | |||
| text-align: start; | |||
| } | |||
|
|
|||
| strong { | |||
36degrees
Mar 2, 2017
•
Member
It might then make sense to move the .rich-govspeak strong there too…
It might then make sense to move the .rich-govspeak strong there too…
fofr
Mar 2, 2017
Author
Contributor
I left it here as it's next to the rich-govspeak declaration that overrides it.
I left it here as it's next to the rich-govspeak declaration that overrides it.
36degrees
Mar 2, 2017
Member
Talked about this IRL. I suggested that we should move both strong declerations into govspeak/typography and add a comment there that rich-govspeak is a… Govspeak ‘modifier’(?) than re-enables bold.
Talked about this IRL. I suggested that we should move both strong declerations into govspeak/typography and add a comment there that rich-govspeak is a… Govspeak ‘modifier’(?) than re-enables bold.
We don’t allow bold text in markdown except for specific places where rich-govspeak is enabled (eg the highway code manual) If an app uses `core-layout` then they use a reset that sets strong to bold. See: #483 Any app using core-layout and the govspeak component would render the `strong` text in bold. This is a regression that has gradually affected a great proportion of content. (Whitehall does not set `strong` styles) * Be explicit about strong being rendered as normal text * Rich-govspeak will continue to enable * This will work with whatever flavour of CSS reset an app has
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We don’t style bold text in markdown except for specific places where rich-govspeak is enabled (eg the highway code manual), see #657
If an app uses
core-layoutthen it uses a reset that styles strong as bold. See: #483. Any app using core-layout and the govspeak component would render thestrongtext in bold. This is a regression that has gradually affected a greater proportion of content as we have migrated.Whitehall did not set
strongstyles, so bold was not used in content.Our style guide says:
This PR means we are:
Other reading on our approach to bold:
https://gdsengagement.blog.gov.uk/2016/11/28/how-to-make-blog-posts-accessible/
https://www.gov.uk/guidance/style-guide/a-to-z-of-gov-uk-style#bold
https://www.gov.uk/design-principles/accessiblepdfs#use-headings
We correctly omit bold from our markdown guidance here:
https://www.gov.uk/guidance/how-to-publish-on-gov-uk/markdown
cc @markhurrell