Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning callout print styles to govspeak component #927

Merged
merged 2 commits into from Mar 14, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 6, 2017

Add styles to the help-notice block in govspeak when printing

Part of alphagov/government-frontend#274 and https://trello.com/c/MluRcP1W/

  • Help notices need to be visually stronger
  • The call to action is in bold, print in bold too
  • The background image won’t print, use a border instead – matching other calls to action

When not printing

screen shot 2017-03-06 at 11 47 30

Print styles before

screen shot 2017-03-06 at 11 45 10

Print styles after

screen shot 2017-03-06 at 11 44 09

cc @36degrees

fofr added 2 commits Mar 6, 2017
Information blocks were removed in
943d1e1

See: #899
* Help notices need to be visually stronger
* The call to action is in bold, print in bold too
* The background image won’t print, use a border instead – matching
other calls to action
@36degrees 36degrees self-requested a review Mar 13, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 13, 2017

@36degrees Happy for me to merge this? I'd like to deploy before we switch Travel Advice to government-frontend.

@36degrees
Copy link
Member

@36degrees 36degrees commented Mar 14, 2017

Sorry! That was meant to be an approval I added yesterday 🤦‍♂️

@fofr fofr merged commit ddb85b0 into master Mar 14, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the print-important-block branch Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.