Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render govspeak contact details inline for legibility #934

Merged
merged 1 commit into from Mar 9, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 7, 2017

Fix was made to Whitehall after styles were cut for govspeak component.

Old Whitehall

http://webarchive.nationalarchives.gov.uk/+/https://www.gov.uk/government/news/future-life-expectancy-to-be-considered-in-first-state-pension-age-review

screen shot 2017-03-07 at 13 34 05

Component

screen shot 2017-03-07 at 13 28 35

Component after fix

screen shot 2017-03-07 at 13 28 16

Port fix from alphagov/whitehall#2367
Addresses https://govuk.zendesk.com/agent/tickets/1918092

Fix was made to Whitehall after styles were taken for govspeak
component.
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Mar 8, 2017

Looks good to me 👍

Can you recommend a way to test this?

@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 8, 2017

@nickcolley Look at this on government-frontend with latest static: https://www.gov.uk/government/news/future-life-expectancy-to-be-considered-in-first-state-pension-age-review

Run against the component guide.

@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Mar 9, 2017

Tested it 👍

@nickcolley nickcolley merged commit 6e11b83 into master Mar 9, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@nickcolley nickcolley deleted the inline-govspeak-contacts branch Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.