From 144b1170dbeae233b8146e5308de5592b386494a Mon Sep 17 00:00:00 2001 From: David Thompson Date: Wed, 18 Jun 2014 09:34:29 +0100 Subject: [PATCH] Sneak in an extra grammar fix or two. You know, while @ajlanghorn's in there already. --- puppet.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/puppet.md b/puppet.md index 12d1ec6..e620d87 100644 --- a/puppet.md +++ b/puppet.md @@ -7,13 +7,13 @@ ## Things that should not be in the Puppet Repo -- **Secrets.** It is bad practise to embed your secret data (passwords, +- **Secrets.** It is bad practice to embed your secret data (passwords, tokens) within Puppet. To do so means that even if you specify that a secret applies to one particular environment it is available on the PuppetMaster for every environment. It is good practise to store secrets in the `deployment` repo at `Puppet/hieradata/${environment}.yaml`. Please make sure where necessary you have different secrets for each value. -- **Per Environment switches**. The Puppet repo should not know the +- **Per-environment switches**. The Puppet repo should not know the specifics of each environment. By switching on platform or environment variables, you make it difficult to add new platforms and hard to ensure that consistent behaviour is applied across all environments. To apply a