Permalink
Commits on Jul 5, 2016
  1. @dsingleton

    Merge pull request #93 from alphagov/update-module-definition

    Update example for GOVUK modules to be consistent with current codebase
    dsingleton committed on GitHub Jul 5, 2016
  2. @nickcolley

    Update example for GOVUK modules to be consistent with current codebase

    Updated to reflect @colinrotherham 's changes to enable support for module loaders.
    alphagov/govuk_frontend_toolkit#290
    (Hopefully in the future we can remove this boilerplate in favour of a proper module system 🙌 )
    nickcolley committed Jul 5, 2016
Commits on Jul 4, 2016
  1. @alext

    Merge pull request #91 from 36degrees/patch-1

    Fix a couple of typos in the css style guide
    alext committed on GitHub Jul 4, 2016
  2. @alext

    Merge pull request #92 from 36degrees/patch-2

    Fix a couple of typos in the ruby style guide
    alext committed on GitHub Jul 4, 2016
  3. @36degrees
  4. @36degrees
Commits on Jun 27, 2016
  1. @MatMoore

    Merge pull request #90 from alphagov/testing

    Add a styleguide for testing.
    MatMoore committed on GitHub Jun 27, 2016
Commits on Jun 23, 2016
  1. @elliotcm

    Add a styleguide for testing.

    Much of the fine detail is encoded in our Rails
    app templates.
    elliotcm committed Jun 23, 2016
Commits on Apr 25, 2016
  1. @tijmenb

    Merge pull request #89 from freerange/clarify-wording-in-use-of-readmes

    Clarify wording about Smart Answers in use-of-READMEs.md
    tijmenb committed Apr 25, 2016
  2. @floehopper

    Clarify wording about Smart Answers in use-of-READMEs.md

    In the list of bad examples it wasn't obvious to me that the link to the Smart
    Answers README was for an old version of the app. The previous wording implied
    to me that the current version of the Smart Answer README is "bad" when it is
    not.
    
    Likewise in the list of good examples, it wasn't obvious to me what "modern"
    Smart Answers meant.
    floehopper committed Apr 25, 2016
  3. @tijmenb

    Merge pull request #88 from freerange/replace-tabs-with-strings

    Replace tab characters with two spaces
    tijmenb committed Apr 25, 2016
Commits on Apr 11, 2016
  1. @floehopper

    Replace tab characters with two spaces

    Several documents in this repo mandate using soft-tabs with a two-space indent,
    so it seems only sensible to do it in this file too.
    floehopper committed Apr 11, 2016
Commits on Feb 26, 2016
  1. @benlovell

    Merge pull request #85 from erikse/remove_if_unless_modifier_in_ruby

    Remove `IfUnlessModifier` from Ruby style guide
    benlovell committed Feb 26, 2016
  2. @erikse

    Remove `IfUnlessModifier` from Ruby style guide

    This cop is disabled in govuk-lint since version 0.7.0.
    erikse committed Feb 26, 2016
Commits on Feb 5, 2016
  1. @benlovell

    Merge pull request #84 from alphagov/calling-ruby-methods

    Guidance for calling methods with multiple args
    benlovell committed Feb 5, 2016
  2. @benlovell

    Guidance for calling methods with multiple args

    I've noticed various styles being used throughout the projects and
    wanted to try and settle upon some recognised style for calling methods
    with multiple arguments spanning multiple lines. My preferred style is
    the one described as `#good`. I know others prefer `#bad`.
    
    My view is the `#good` style apes our guidance for literal arrays and
    hashes and adds readability. Often what can happen is those arguments
    are indented at the opening paren level and can be missed or obscured
    for those of us with 80 (and for some measures greater) char terminals.
    
    If this gets general approval, I'll add a cop to `alphagov/govuk-lint`
    and revisit this guidance with a referral to said cop.
    benlovell committed Feb 5, 2016
Commits on Feb 3, 2016
  1. @tombye

    Merge pull request #80 from gemmaleigh/master

    Add a link to a supporting article from Léonie
    tombye committed Feb 3, 2016
Commits on Jan 20, 2016
  1. @bradwright

    Merge pull request #83 from alphagov/h-lame-patch-1

    Prefer blank lines around access modifiers
    bradwright committed Jan 20, 2016
  2. @h-lame

    Prefer blank lines around access modifiers

    There's no cop available to enforce our current "blank line before, nothing after" rule so we can only enforce this using humans.  To reduce the burden we should change our guide to something that is enforcable by a cop (Style/EmptyLinesAroundAccessModifier) and is more in line with the global ruby community reckons expressed in https://github.com/bbatsov/ruby-style-guide#indent-public-private-protected.
    h-lame committed Jan 20, 2016
Commits on Jan 19, 2016
  1. @benlovell

    Merge pull request #82 from Davidslv/patch-2

    Adds link to point what ARIA means
    benlovell committed Jan 19, 2016
  2. @Davidslv

    Adds link to point what ARIA means

    Trying to avoid confusion when reading ARIA and adds a link pointing to the explanation.
    Davidslv committed Jan 19, 2016
  3. @benlovell

    Merge pull request #81 from Davidslv/patch-1

    fixes typo in word "variable"
    benlovell committed Jan 19, 2016
  4. @Davidslv

    fixes typo in word "variable"

    Davidslv committed Jan 19, 2016
Commits on Jan 11, 2016
  1. @gemmaleigh

    Add a link to a supporting article from Léonie

    This article explains why it is best to use the ARIA landmark
    role=“navigation” on the nav tag.
    gemmaleigh committed Jan 11, 2016
Commits on Jan 5, 2016
  1. @daibach

    Merge pull request #79 from alphagov/pr

    Edit Pull Request styleguide
    daibach committed Jan 5, 2016
  2. @daibach @daibach

    Add examples of further reading

    Anna Shipman’s blog is a useful description of how to raise a good pull
    request and Alice Bartlett’s pull request is a great example of one.
    
    Both of these are useful things to look at for people reading our
    guidance.
    daibach committed with daibach Jan 5, 2016
Commits on Dec 30, 2015
  1. @annashipman

    Make questions into proper headings

    According to our
    [guidance](https://www.gov.uk/guidance/content-design/writing-for-gov-uk) titles
    should be clear and descriptive of what you will find below.
    
    This change also meant I reworded the bullets in 'cautionary notes' and removed
    the one that is duplicated below.
    annashipman committed Dec 29, 2015
  2. @annashipman

    Re-organise into sections

    There are three kinds of advice here; group them.
    annashipman committed Dec 29, 2015
  3. @annashipman
  4. @annashipman

    Put similar points together

    annashipman committed Dec 29, 2015
  5. @annashipman

    This is crucial, not an aside

    Move it up to an important bullet rather than a "don't forget" at the end.
    annashipman committed Dec 29, 2015
  6. @annashipman

    Clarify 'definition of done'

    I've changed what was written before into a specific instruction the reviewer,
    which is what this section is for.
    annashipman committed Dec 29, 2015
  7. @annashipman
  8. @annashipman

    Remove repetition

    annashipman committed Dec 29, 2015
  9. @annashipman

    Attempt to clarify this point

    I'm not entirely sure what was meant by this point as it slightly reads as an
    appeal to management to allot time for PR-reviewing. I think the useful point
    here is "reviewer - this is important so do it properly" so that's what I've
    tried to capture with this change.
    annashipman committed Dec 29, 2015