Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more lenient on the referrers we accept #115

Merged
merged 1 commit into from Aug 9, 2017
Merged

Be more lenient on the referrers we accept #115

merged 1 commit into from Aug 9, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 8, 2017

Only check that a URI can be parsed.

Referrer URLs can come from a variety of places eg web URLs as well as
app URLs such as “android-app://com.google.android.googlequicksearchbox”

Before this change we were rejecting otherwise valid feedback from
Android users.

https://trello.com/c/lF8Yated/66-2-http-feedback-frontend-error
https://errbit.publishing.service.gov.uk/apps/5319fd4f0da11511b00017c3/problems/597880526578634a2e330200

@h-lame
h-lame approved these changes Aug 8, 2017
Copy link
Contributor

@h-lame h-lame left a comment

Looks like a sensible approach, and it doesn't sound like this would drastically increase the number of entries the support team have to deal with.

Only check that a URI can be parsed.

Referrer URLs can come from a variety of places eg web URLs as well as
app URLs such as “android-app://com.google.android.googlequicksearchbox”

Before this change we were rejecting otherwise valid feedback from
Android users.
@fofr fofr force-pushed the more-referrer-urls branch from b2fe3cb to 7c9b948 Aug 9, 2017
@fofr fofr merged commit 1d3d22f into master Aug 9, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the more-referrer-urls branch Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.