Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch global export to s3 #415

Merged
merged 4 commits into from Feb 6, 2020
Merged

Switch global export to s3 #415

merged 4 commits into from Feb 6, 2020

Conversation

@benjamineskola
Copy link
Contributor

benjamineskola commented Feb 6, 2020

Use S3 to transfer files, to be consistent with other emails and also compatible (in future) with Notify.

This is reapplying #411 and fixing a bug it introduced. (Reverted in #413.)

The actual fix compared with #411 is quite small: use public_url not key, and ensure that public: true is set when creating the file. I've also added tests to ensure that this is correct — the problem previously was that although uploading was tested, and sending the email was also tested, the email was sent with a dummy URL and the step of generating an email using the data from the upload step (i.e., the call to .notification_email().deliver_now was never tested).

https://trello.com/c/V9wtOj6x/1713-3-support-api-make-globalcsvexport-use-s3-instead-of-email-attachments

@issyl0
issyl0 approved these changes Feb 6, 2020
@issyl0 issyl0 merged commit 0f69bda into master Feb 6, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/security No security issues found
Details
@issyl0 issyl0 deleted the switch-global-export-to-s3 branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.