Skip to content
Commits on Nov 5, 2015
  1. @benlovell
  2. @benlovell
  3. @benlovell

    Validate training options

    benlovell committed Nov 5, 2015
    Ensure when no options were checked, the `other_training` field is
    provided.
  4. @benlovell

    Validate provided training options

    benlovell committed Nov 5, 2015
    Ensures the provided checkbox options are present in the permitted
    `TRAINING_OPTIONS`. Also moves the training options into a constant.
    
    The regular `inclusion` validation could not be used here since
    `training` can contain multiple options.
Commits on Nov 4, 2015
  1. @benlovell

    Add structured fields for user training

    benlovell committed Nov 3, 2015
    Replaces the unstructured text field for specifying which training
    courses the proposed user has received. The checkboxes for 'Writing for
    GOV.UK' and 'Using Whitehall Publisher' appear in Zendesk in formatted
    sentence.
Commits on Nov 3, 2015
  1. @benlovell
Commits on Oct 14, 2015
  1. @binaryberry

    Add training information to create or change user

    binaryberry committed Oct 14, 2015
    When deciding on granting user permissions, people need to know
    what previous training users have had.
Commits on Oct 13, 2015
  1. @binaryberry

    Add other permissions checkbox

    binaryberry committed Oct 12, 2015
    Users can select other permissions in addition of Whitehall user account options,
    or instead of them. This change includes validations around account options,
    to ensure at least one is selected. It also rescues errors from the gds_zendesk gem
    that occurred during local testing.
  2. @binaryberry

    Turn Whitehall permissions into radio buttons

    binaryberry committed Sep 29, 2015
    Improved copy. Instead of using checkboxes to select which permissions are needed,
    users can select the type of whitehall account they want. Multiple choices are no longer
    necessary so those are radio buttons.
  3. @binaryberry
  4. @benilovj

    Update the 'gds_zendesk' gem to 2.0.0

    benilovj committed Oct 13, 2015
    This picks up the fix to the "Create or update user request"
    form (the form submission broke in development).
    
    This commit also involves removing the unused field mappings
    refernce, as field mappings have been removed from `gds_zendesk`.
Commits on Sep 22, 2015
  1. @jamiecobbett

    Use TimeConstraint for ContentAdviceRequests

    jamiecobbett committed Sep 22, 2015
    Reuse the TimeConstraint code, rather than reimplementing it.
    
    This also makes it so that the time constraint reason is always included, if it
    is present.
  2. @jamiecobbett

    Move date constraints to the comment field in Zendesk

    jamiecobbett committed Sep 22, 2015
    Sending them as custom fields caused a few problems:
    * they were disabled in Zendesk (thanks to bad UI in the field management), so
    were being discarded
    * they weren't displayed unless the user turned on "Show all events"
    
    By moving them to the "comment" field, we avoid these problems.
Commits on May 21, 2015
  1. @mikejustdoit

    Redirect Explore by organisation to summary page

    mikejustdoit committed May 19, 2015
    Small caveat: the view for this page doesn't exist yet, we're starting with the
    controller
  2. @mikejustdoit

    ExploreByOrganisation model

    mikejustdoit committed May 15, 2015
    Similar to ExploreByUrl, to be used from the /explore controller to validate
    form fields and redirect correctly
  3. @mikejustdoit
Commits on May 15, 2015
  1. @benilovj

    Remove anonymous feedback models

    benilovj committed May 13, 2015
    They are no longer used.
  2. @benilovj
Commits on May 11, 2015
  1. @mikejustdoit

    Merge pull request #233 from alphagov/remove-corporate-content-pp-upload

    mikejustdoit committed May 11, 2015
    Remove corporate content PP upload
Commits on May 8, 2015
  1. @benilovj

    Remove the corporate content PP upload

    benilovj committed May 8, 2015
    This is moving to the Support API, where it would be closer to the
    data. Architecturally, the Support app is a frontend app and shouldn't
    be responsible for data feeds.
Commits on May 7, 2015
  1. @benilovj

    Bugfix on content advice requests

    benilovj committed May 7, 2015
    Before this fix, the nature of the request was not being sent to Zendesk if
    the user has picked their own reason.
Commits on Apr 30, 2015
  1. @fofr @benilovj

    Test path handling with unit test

    fofr committed with benilovj Apr 30, 2015
    Avoid testing at integration stage as this is slower and obscures the
    purpose of that test.
  2. @fofr @benilovj

    Leniently accept malformed URLs

    fofr committed with benilovj Apr 29, 2015
    * Strip out variations on http
      eg http:/, http//:, http//, http:///
    * Allow paths without a leading slash: treat `vat-rates` as if it were
    `/vat-rates`
  3. @fofr @benilovj

    Be lenient in what feedback URL can receive

    fofr committed with benilovj Apr 29, 2015
    Allow full URLs with http and https, as well as partial URLs beginning
    with gov.uk or www.gov.uk, or simply the plain path itself.
    
    The following examples all give the same results:
    https://www.gov.uk/vat-rates
    http://www.gov.uk/vat-rates
    www.gov.uk/vat-rates
    gov.uk/vat-rates
    /vat-rates
    
    Also removes inline form validation – what the browser validation
    defines as a URL is too strict.
Commits on Apr 28, 2015
  1. @fofr

    Improve page and html titles

    fofr committed Apr 28, 2015
    Shorter, more legible.
Commits on Apr 20, 2015
  1. @benilovj

    Replace hand-rolled TablelessModel with ActiveModel::Model

    benilovj committed Apr 16, 2015
    Since the move to Rails 4.0, it's possible to use the ActiveModel::Model
    for models that aren't backed by a database. This change removes the hand-rolled
    implementation.
    
    More info here:
    http://blog.plataformatec.com.br/2012/03/barebone-models-to-use-with-actionpack-in-rails-4-0/
Commits on Mar 30, 2015
  1. @benilovj @issyl0

    Update record grouping when calculating feedback counts

    benilovj committed with issyl0 Mar 13, 2015
    Grouping has a different syntax in ActiveRecord 4.1.9
  2. @issyl0

    Rails 4 deprecates `attr_accessible` - remove all lines referencing it

    issyl0 committed Mar 11, 2015
    - Rails 4 replaces `attr_accessible` in favour of strong parameters.
      However, none of the models (or code in `lib/`) here deal with
      writing to these, only reading from them.
Commits on Feb 23, 2015
  1. @issyl0
Commits on Oct 9, 2014
  1. @benilovj

    Anonymous feedback: use 'path' instead of 'url' everywhere

    benilovj committed Oct 9, 2014
    All anonymous feedback is now being created through the 'support-api'.
    When persisting the feedback, the 'url' is no longer being set and this app
    shouldn't be relying on it being set.
    
    This fixes the issue with broken links in Feedex and missing URLs in the Feedex API.
Commits on Oct 4, 2014
  1. @benilovj

    Remove endpoint for creating problem reports

    benilovj committed Oct 4, 2014
    This endpoint has been moved to the 'support-api' app.
  2. @benilovj

    Remove endpoint for creating long-form feedback

    benilovj committed Oct 4, 2014
    This endpoint has now been moved to the 'support-api'; long-form feedback is now
    read-only in this app.
Commits on Sep 4, 2014
  1. @benilovj

    Remove code relating to deduplication

    benilovj committed Sep 4, 2014
    Deduplication has been moved to the `support-api`.
Commits on Aug 31, 2014
  1. @benilovj

    Simplify `gds-sso` user mocking

    benilovj committed Aug 29, 2014
    This change sets the `gds-sso` test user automatically in development mode
    whenever SSO is mocked out. This means that:
    * it's no longer necessary to run a rake task once a day to run this app in development.
    * 2 methods from `User` (that were only used in SSO mocking mode) can be dropped.
Commits on Aug 28, 2014
  1. @benilovj

    Remove code relating to service feedback stats upload

    benilovj committed Aug 28, 2014
    This has been moved to the `support-api`.
Something went wrong with that request. Please try again.