Create a date picker more in keeping with the Bootstrap styles used by the admin template. Specifically: * No gradients * Larger hit points for accurate selection * Larger fonts for legibility * Use Bootstrap colours Default styles are not included and the source HTML is styled from scratch.
Just a case of one in a group of examples using the wrong `path` query parameter for the request that's already stubbed for it within the setup for its group. If RSpec always runs these specs in order and we're not clearing up after creating our WebMock stubs, later specs will have access to earlier specs' request stubs.
This was causing a failure in the Feedex spec, where its API response looked suspiciously similar to the one specified in the Redirects spec. But according to the WebMock documentation (https://github.com/bblimke/webmock#precedence-of-stubs) each of our calls to `stub_anonymous_feedback` should take precedence over the last. I don't really understand how having RSpec run our specs in a different order would have changed this.
Under normal circumstances this test passes on master. I was working on a branch that contained seemingly unrelated changes and when I rebased against master, this test started failing. I only actually managed to get it failing on master running `bundle exec rspec --seed 1`, which I don't really understand.
When JSON is requested, the Support app just passes back the response from the Support API. This means that the jbuilder templates aren't necessary any more.
Bump version of 'formtastic-bootstrap' gem; this picks up a bugfix (mjbellantoni/formtastic-bootstrap#119) which is currently unreleased to rubygems.
Commit 83fab62 (which was included in #219) inadvertently introduced a bug whereby any unexpected parameter in a POST submission would result in a 500 error. This was a serious problem because the 'feedback' app is submitting requests with extra (unnecessary) fields for certain requests, including the public support form requests and the FOI requests. This change introduces strong params into all controller actions that receive form submissions. Acceptable parameters are now explicitly whitelisted, meaning that unexpected parameters are thrown away. The next step after this is to stop the 'feedback' app from submitting unexpected params.
The long referrer URLs are often unreadable, squished onto multiple lines and unusable. * For external sites show only the hostname (stripping out `www` as well) * When a search has been performed (when there is a “q” parameter), extract and show the search term * When referred internally, show only the gov.uk path * All links continue to link through to the full referrer * When referrer is unknown or blank, leave an empty cell