Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 19, 2015
  1. @fofr @binaryberry

    Indicate today in jQuery UI calendar

    fofr authored binaryberry committed
  2. @fofr @binaryberry

    Re-style jQuery UI date picker

    fofr authored binaryberry committed
    Create a date picker more in keeping with the Bootstrap styles used by
    the admin template. Specifically:
    
    * No gradients
    * Larger hit points for accurate selection
    * Larger fonts for legibility
    * Use Bootstrap colours
    
    Default styles are not included and the source HTML is styled from
    scratch.
  3. @benilovj

    Merge pull request #237 from alphagov/stub-requests-in-specs

    benilovj authored
    Stub requests in specs
Commits on May 18, 2015
  1. @mikejustdoit

    Use stubbed request for controller example

    mikejustdoit authored
    Just a case of one in a group of examples using the wrong `path` query parameter
    for the request that's already stubbed for it within the setup for its group.
    
    If RSpec always runs these specs in order and we're not clearing up after
    creating our WebMock stubs, later specs will have access to earlier specs'
    request stubs.
  2. @mikejustdoit

    Don't reuse "/vat-rates" example path

    mikejustdoit authored
    This was causing a failure in the Feedex spec, where its API response looked
    suspiciously similar to the one specified in the Redirects spec.
    
    But according to the WebMock documentation
    (https://github.com/bblimke/webmock#precedence-of-stubs) each of our calls to
    `stub_anonymous_feedback` should take precedence over the last. I don't really
    understand how having RSpec run our specs in a different order would have
    changed this.
  3. @mikejustdoit

    Stub request from Redirects spec

    mikejustdoit authored
    Under normal circumstances this test passes on master. I was working on a
    branch that contained seemingly unrelated changes and when I rebased against
    master, this test started failing. I only actually managed to get it failing on
    master running `bundle exec rspec --seed 1`, which I don't really understand.
Commits on May 15, 2015
  1. @boffbowsh

    Merge pull request #235 from alphagov/feedex-uses-the-support-api

    boffbowsh authored
    Change FeedEx to use the Support API to fetch feedback
  2. @benilovj
  3. @benilovj

    Clean up database dependencies

    benilovj authored
    The Support app no longer uses MySQL and ActiveRecord.
    
    - turn off ActiveRecord
    - delete schema.rb and all migrations
    - remove database.yml
    - remove the mysql2 gem
  4. @benilovj

    Remove anonymous feedback models

    benilovj authored
    They are no longer used.
  5. @benilovj
  6. @benilovj

    Remove the jbuilder gem

    benilovj authored
    It's no longer used.
  7. @benilovj

    Use the support-api for getting anonymous feedback

    benilovj authored
    When JSON is requested, the Support app just passes back the response
    from the Support API. This means that the jbuilder templates aren't necessary
    any more.
  8. @benilovj

    Update gds-api-adapters

    benilovj authored
    This update is necessary to access the `/anonymous-feedback` endpoint in support-api.
Commits on May 13, 2015
  1. @mikejustdoit @benilovj

    Add an AnonymousFeedbackPresenter

    mikejustdoit authored benilovj committed
    An object for presenting support-api's data in a format compatible with
    Feedback Explorer's existing views.
Commits on May 11, 2015
  1. @benilovj

    Merge pull request #234 from alphagov/better-feedback-formatting

    benilovj authored
    Improve formatting of anonymous feedback
  2. @fofr

    Shorten date display

    fofr authored
    Shorten date so the table has more space for displaying feedback
    information.
  3. @fofr

    Improve layout of action/problem feedback

    fofr authored
    Make the action/problem feedback more legible by
    * removing visible labels
    * capitalising the start of each action/problem
    * visibly rendering the action as a heading for the problem
    
    Also removes hover styles that interrupt reading.
  4. @mikejustdoit

    Merge pull request #233 from alphagov/remove-corporate-content-pp-upload

    mikejustdoit authored
    Remove corporate content PP upload
Commits on May 8, 2015
  1. @mikejustdoit

    Merge pull request #232 from alphagov/introduce-strong-params

    mikejustdoit authored
    Introduce strong params for all incoming POST requests
  2. @mikejustdoit

    Merge pull request #231 from alphagov/fix-double-checkbox-label

    mikejustdoit authored
    Fix label appearing twice on 'Request to unpublish content' form
  3. @mikejustdoit

    Merge pull request #230 from alphagov/other-reason-not-sent-to-zendes…

    mikejustdoit authored
    …k-on-content-advice-requests
    
    Bugfix on content advice requests
  4. @benilovj

    Remove 'whenever' gem

    benilovj authored
    There aren't any scheduled tasks remaining in this app.
  5. @benilovj

    Remove the corporate content PP upload

    benilovj authored
    This is moving to the Support API, where it would be closer to the
    data. Architecturally, the Support app is a frontend app and shouldn't
    be responsible for data feeds.
Commits on May 7, 2015
  1. @benilovj

    Fix label appearing twice on 'Request to unpublish content' form

    benilovj authored
    Bump version of 'formtastic-bootstrap' gem; this picks up a bugfix (mjbellantoni/formtastic-bootstrap#119)
    which is currently unreleased to rubygems.
  2. @benilovj

    Bugfix on content advice requests

    benilovj authored
    Before this fix, the nature of the request was not being sent to Zendesk if
    the user has picked their own reason.
  3. @benilovj

    Introduce strong params for all incoming POST requests

    benilovj authored
    Commit 83fab62 (which was included in #219) inadvertently
    introduced a bug whereby any unexpected parameter in a POST submission
    would result in a 500 error.
    
    This was a serious problem because the 'feedback' app is submitting
    requests with extra (unnecessary) fields for certain requests, including
    the public support form requests and the FOI requests.
    
    This change introduces strong params into all controller actions that
    receive form submissions. Acceptable parameters are now explicitly whitelisted,
    meaning that unexpected parameters are thrown away. The next step after this
    is to stop the 'feedback' app from submitting unexpected params.
  4. @binaryberry

    Merge pull request #229 from alphagov/fix-spec-name

    binaryberry authored
    Fix name of unpublish content request spec
  5. @benilovj

    Fix name of unpublish content request spec

    benilovj authored
    Without the _spec suffix, the spec isn't picked up automatically
    by RSpec and is consequently not executed as part of the build.
Commits on May 6, 2015
  1. @benilovj

    Merge pull request #227 from alphagov/feedex-homepage

    benilovj authored
    Improve feedex homepage
  2. @fofr

    Improve feedex homepage

    fofr authored
    * Make the form clearer
    * Use a better explanation of where the feedback comes from
Commits on May 5, 2015
  1. @benilovj

    Merge pull request #226 from alphagov/better-referrer

    benilovj authored
    Make the referrer column user friendly
  2. @fofr

    Make search term clearer

    fofr authored
  3. @fofr

    Make the referrer column user friendly

    fofr authored
    The long referrer URLs are often unreadable, squished onto multiple
    lines and unusable.
    
    * For external sites show only the hostname (stripping out `www` as
    well)
    * When a search has been performed (when there is a “q” parameter),
    extract and show the search term
    * When referred internally, show only the gov.uk path
    * All links continue to link through to the full referrer
    * When referrer is unknown or blank, leave an empty cell
Commits on Apr 30, 2015
  1. @benilovj

    Merge pull request #222 from alphagov/better-url-handling

    benilovj authored
    Be lenient in what the feedback explorer can receive in its URL field
Something went wrong with that request. Please try again.