Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of anonymous feedback #234

Merged
merged 2 commits into from May 11, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 10, 2015

Make the action/problem feedback more legible by

  • removing visible labels
  • capitalising the start of each action/problem
  • visibly rendering the action as a heading for the problem

Before

screen shot 2015-05-10 at 10 34 50

After

screen shot 2015-05-10 at 10 34 28

cc @benilovj @rivalee

@benilovj
Copy link
Contributor

@benilovj benilovj commented May 11, 2015

I think that this is a good improvement.

The only thing is that we can't hide the duplicate dates until we have CSV export, because there are users who "export" FeedEx data by copying and pasting the table. Could we:

  • take the removal of the date duplication into another PR
  • merge the other changes her
  • merge the other PR when CSV export is done?
@fofr fofr force-pushed the better-feedback-formatting branch from 6f59ac8 to 60e2ca7 May 11, 2015
@fofr
Copy link
Contributor Author

@fofr fofr commented May 11, 2015

@benilovj I've rebased and removed date hiding, for now. A commit for the shorter date remains.

<strong>action</strong>: <%= anonymous_contact.what_doing %>
<br/>
<strong>problem</strong>: <%= anonymous_contact.what_wrong %>
<% if anonymous_contact.what_doing %>

This comment has been minimized.

@benilovj

benilovj May 11, 2015
Contributor

You might want to do if anonymous_contact.what_doing.present? here to guard against what_doing being an empty string.

<%= anonymous_contact.what_doing.capitalize %>
</div>
<% end %>
<% if anonymous_contact.what_wrong %>

This comment has been minimized.

@benilovj

benilovj May 11, 2015
Contributor

as above

This comment has been minimized.

@fofr

fofr May 11, 2015
Author Contributor

Fixed and rebased.

fofr added 2 commits May 10, 2015
Make the action/problem feedback more legible by
* removing visible labels
* capitalising the start of each action/problem
* visibly rendering the action as a heading for the problem

Also removes hover styles that interrupt reading.
Shorten date so the table has more space for displaying feedback
information.
@fofr fofr force-pushed the better-feedback-formatting branch from 60e2ca7 to de2815b May 11, 2015
benilovj added a commit that referenced this pull request May 11, 2015
Improve formatting of anonymous feedback
@benilovj benilovj merged commit 1014368 into master May 11, 2015
1 check passed
1 check passed
default "Build #177 succeeded on Jenkins"
Details
@benilovj benilovj deleted the better-feedback-formatting branch May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.