Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brexit checker #731

Merged
merged 5 commits into from Feb 5, 2020
Merged

Update Brexit checker #731

merged 5 commits into from Feb 5, 2020

Conversation

@laurentqro
Copy link
Contributor

laurentqro commented Feb 4, 2020

What

Zendesk has a support request form called Get ready for Brexit checker: change request so departments can request amendments to existing checker actions or add new actions.

We want to reuse the form for future change requests but first it needs updating to reflect changes in the checker, including language, for example "Brexit" to "transition".

We want to remind departments about the existence of the form and encourage them to use it over the coming months. It would be useful to contact Department sooner rather than later. The earlier we can change the form, the earlier we can do this.

Why

We need a managed workflow for making changes to the checker. The Zendesk form is part of the workflow.

https://trello.com/c/zyFtYQex/448-amend-zendesk-form-for-checker-requests

@laurentqro laurentqro force-pushed the update-brexit-checker branch 2 times, most recently from 001a4ca to f4cec15 Feb 5, 2020
@huwd
huwd approved these changes Feb 5, 2020
Copy link

huwd left a comment

Looks good, but some integration tests are failing

@huwd
huwd approved these changes Feb 5, 2020
laurentqro added 5 commits Feb 4, 2020
spec/features/campaign_requests_spec.rb:16 fails intermittently.
I suspect this is dependent on the order on which the test cases
are run. Transactional fixtures should fix this by making sure
each test case runs in isolation.
@laurentqro laurentqro force-pushed the update-brexit-checker branch from d97fdde to 8721385 Feb 5, 2020
@laurentqro laurentqro merged commit afe6114 into master Feb 5, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/security No security issues found
Details
@laurentqro laurentqro deleted the update-brexit-checker branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.