From 43d03096ffea5165d194b54829fb46477789f3e0 Mon Sep 17 00:00:00 2001 From: George Lund Date: Fri, 31 Oct 2025 13:17:55 +0000 Subject: [PATCH 1/3] Fix instruction for running jasmine tests --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9c0781b6..746997df 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ This repository contains automated JavaScript tests that use the [Jasmine test f You can run these tests and see the results in your browser. -1. Run `bundle exec rake jasmine`. +1. Run `bundle exec rake jasmine:server`. 2. Go to `http://localhost:8888` in your browser. To run the tests and see the results in your terminal, run: From 8699368745c569a5d52eb38a2b23689a96150267 Mon Sep 17 00:00:00 2001 From: George Lund Date: Fri, 31 Oct 2025 13:19:22 +0000 Subject: [PATCH 2/3] Option to show alternative logo - using a different logo is specifically [suggested](https://www.gov.uk/service-manual/design/making-your-service-look-like-govuk#if-your-service-isnt-on-govuk) by the Service Manual - use the GDS logo in the example --- example/config/tech-docs.yml | 3 +- .../GDS_Informal_Shorthand_AquaBlock.svg | 37 +++++++++++++++++++ lib/source/layouts/_header.erb | 1 + 3 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 example/source/images/GDS_Informal_Shorthand_AquaBlock.svg diff --git a/example/config/tech-docs.yml b/example/config/tech-docs.yml index 09bb9195..5d523db9 100644 --- a/example/config/tech-docs.yml +++ b/example/config/tech-docs.yml @@ -2,7 +2,8 @@ host: https://docs.example.com # Header-related options -show_govuk_logo: true +show_govuk_logo: false +logo_html: GDS [logo] service_name: My First Service service_link: / phase: Beta diff --git a/example/source/images/GDS_Informal_Shorthand_AquaBlock.svg b/example/source/images/GDS_Informal_Shorthand_AquaBlock.svg new file mode 100644 index 00000000..5b45a80c --- /dev/null +++ b/example/source/images/GDS_Informal_Shorthand_AquaBlock.svg @@ -0,0 +1,37 @@ + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/lib/source/layouts/_header.erb b/lib/source/layouts/_header.erb index 3555ff61..09f1a08d 100644 --- a/lib/source/layouts/_header.erb +++ b/lib/source/layouts/_header.erb @@ -33,6 +33,7 @@ <% end %> + <%= config[:tech_docs][:logo_html] %> <%= config[:tech_docs][:service_name] %> From 0d56ddac4b75268c02702763540d0b3207638430 Mon Sep 17 00:00:00 2001 From: George Lund Date: Fri, 31 Oct 2025 13:23:24 +0000 Subject: [PATCH 3/3] Avoid using $govuk-brand-colour as a background colour - otherwise the text is unreadable if $govuk-brand-colour is too light --- lib/assets/stylesheets/modules/_page-review.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/assets/stylesheets/modules/_page-review.scss b/lib/assets/stylesheets/modules/_page-review.scss index dd449667..bc207478 100644 --- a/lib/assets/stylesheets/modules/_page-review.scss +++ b/lib/assets/stylesheets/modules/_page-review.scss @@ -4,8 +4,7 @@ padding: govuk-spacing(3); margin-top: govuk-spacing(6); margin-bottom: govuk-spacing(6); - background-color: $govuk-brand-colour; - color: govuk-colour("white"); + border: govuk-spacing(1) solid $govuk-brand-colour; @include govuk-media-query(tablet) { padding: govuk-spacing(6);