58794800 edit national footnote in place #140

merged 3 commits into from Jan 22, 2014


None yet

2 participants

saulius commented Jan 22, 2014

This change is for https://www.pivotaltracker.com/story/show/58794800

Adds API endpoint for national footnote editing. Restricted with authentication.

Depends on:

saulius added some commits Jan 21, 2014
@saulius saulius Add Footnote API endpoint 2f777d8
@saulius saulius Enable footnote description updating 6e66379
@saulius saulius Update footnote primary key order
It makes sense to compose it of footnote_type_id + footnote_id. Footnote
type id is indexed 2 char field and is shorter than footnote_id so it's
faster to query.
@saulius saulius referenced this pull request in alphagov/trade-tariff-admin Jan 22, 2014

Implementaiton of National Footnote editing #19

saulius commented Jan 22, 2014

This does in place updates, updating existing national footnotes and keeping their validity periods unchanged. Two unsolved problems are:

  • How do we track/publish/restore these updates in case we want to rebuild the system
  • Do we need to involve validity periods when doing updates, e.g: when I edit a description it ends current valdity period and create a new, unbounded one with new description (this would make sense in my opinion, but is a bit more complex).
@matthewford matthewford merged commit 6d6718c into master Jan 22, 2014

1 check passed

default The Travis CI build passed
@matthewford matthewford deleted the 58794800-edit-national-footnote-in-place branch Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment