Skip to content

Measure change feeds does not return proactively added measures #142

Merged
merged 1 commit into from Feb 3, 2014

2 participants

@saulius
saulius commented Feb 3, 2014

This change is for https://www.pivotaltracker.com/story/show/64645912

How to reproduce? https://www.gov.uk/trade-tariff/commodities/1006209600/changes?as_of=2013-01-31

If I'm querying for commodity changes on 31st of Jan, I should not be seeing Measures that were added on 24th of Jan but have validity start date of 1st of Feb. Showing these causes issues with associations like measure type, because we expect measure type of such measure to be valid at query date (31st of Jan) and if they were introduced at the same time that is not the case (also has validity start date of 1st of Feb).

@saulius saulius Measure change feeds does not return proactively added measures
In other words: if I'm querying for commodity changes on 31st of Jan,
I should not be seeing Measures that were added on 24th of Jan but have
validity start date of 1st of Feb. Showing these causes issues with
associations like measure type, because we expect measure type of such
measure to be valid at query date (31st of Jan) and if they were
introduced at the same time that is not the case (also has validity
start date of 1st of Feb).
4993a04
@matthewford matthewford merged commit 59e968c into master Feb 3, 2014

1 check passed

Details default The Travis CI build passed
@matthewford matthewford deleted the 64645912-hide-proactively-introduced-measures branch Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.