This repository has been archived by the owner on Nov 22, 2017. It is now read-only.
Validity date filter for reference search #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes duplicate referenced results.
Fixes issue with reference search results containing invalid results Extract functionality to smaller, focused classes
matthewford
added a commit
that referenced
this pull request
Mar 20, 2013
Validity date filter for reference search https://www.pivotaltracker.com/story/show/45933843
matthewford
pushed a commit
that referenced
this pull request
Aug 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is additional change is for https://www.pivotaltracker.com/story/show/45933843.
Our synonyms (references) search didn't take into account validity date of the referenced chapter/heading that is why it was suggesting exipred (by search issue date) records. This was fixed along with duplicate removal and correct ordering.
After deployment we should not be seeing most popular heading suggestion 2851 which has validity end date of 31st Dec 2006 (here https://www.gov.uk/trade-tariff/search?utf8=%E2%9C%93&q=trade_tariff&t=water&button=&day=20&month=3&year=2013&country=). But we should still be seeing it before validity end date time, e.g.:
https://www.gov.uk/trade-tariff/search?utf8=%E2%9C%93&q=trade_tariff&t=water&button=&day=20&month=3&year=2005&country=.
Also we should not be seeing duplicate chapters here https://www.gov.uk/trade-tariff/search?utf8=%E2%9C%93&q=trade_tariff&t=alloy&button=&day=20&month=3&year=2014&country= and they should be sorted in correct order.
This change requires reindexing task to be run after deploy.